[PATCH v3 19/23] ref-filter: make populate_value() internal again
- From
Olga Telezhnaya <olyatelezhnaya@gmail.com>
- Date
- Feb 12, 2018, 08:08 UTC
- Message-ID
- <01020161890f4370-4ae9a8d6-4f01-4f56-9fde-c40fd76d69b5-000000@eu-west-1.amazonses.com>
- In-Reply-To
- <01020161890f4236-47989eb4-c19f-4282-9084-9d4f90c2ebeb-000000@eu-west-1.amazonses.com>
Remove populate_value() from header file. We needed that for interim step, now it could be returned back.
Signed-off-by: Olga Telezhnaia <olyatelezhnaya@gmail.com> Mentored-by: Christian Couder <christian.couder@gmail.com> Mentored by: Jeff King <peff@peff.net> --- ref-filter.c | 2 +- ref-filter.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-)
diff --git a/ref-filter.c b/ref-filter.c index eb53b0babdb83..8d104b567eb7c 100644 --- a/ref-filter.c +++ b/ref-filter.c @@ -1428,7 +1428,7 @@ static int check_and_fill_for_cat(struct ref_array_item *ref) * Parse the object referred by ref, and grab needed value. * Return 0 if everything was successful, -1 otherwise. */ -int populate_value(struct ref_array_item *ref) +static int populate_value(struct ref_array_item *ref) { void *buf; struct object *obj; diff --git a/ref-filter.h b/ref-filter.h index 4eaf6d0514502..115d00288fdee 100644 --- a/ref-filter.h +++ b/ref-filter.h @@ -174,9 +174,6 @@ void setup_ref_filter_porcelain_msg(void); void pretty_print_ref(const char *name, const unsigned char *sha1, const struct ref_format *format); -/* Fill the values of request and prepare all data for final string creation */ -int populate_value(struct ref_array_item *ref); - /* Search for atom in given format. */ int is_atom_used(const struct ref_format *format, const char *atom); -- https://github.com/git/git/pull/452