Re: [PATCH v3 06/23] cat-file: split expand_atom() into 2 functions
- From
Jeff King <peff@peff.net>
- Date
- Feb 15, 2018, 05:28 UTC
- Message-ID
- <20180215052840.GF18780@sigill.intra.peff.net>
- In-Reply-To
- <01020161890f433d-ba3260aa-b9e5-47d0-8e80-46ccf9f8c60f-000000@eu-west-1.amazonses.com>
On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:
Show 5 quoted lines
> Split expand_atom() into 2 different functions, > mark_atom_in_object_info() prepares variable for further filling, > (new) expand_atom() creates resulting string. > Need that for further reusing of formatting logic from ref-filter. > Both functions will be step-by-step removed by the end of this patch.
Hmm, this is duplicating the list of atoms. One of the reasons for the mark_query flag in the original is to have a single list, so that it can't go out of sync. So I'd hope to see this split go away by the end of the series...
-Peff