Re: [PATCH v3 21/23] for-each-ref: tests for new atoms added

From: Оля Тележная <olyatelezhnaya@gmail.com>
Date: Feb 15, 2018, 10:38 UTC
Message-ID: <CAL21Bmk6vcyKLDMdd9+Q-mt3huUEguO2fEaHFbce0hWNTE8h6g@mail.gmail.com>
In-Reply-To: <20180215055711.GQ18780@sigill.intra.peff.net>

2018-02-15 8:57 GMT+03:00 Jeff King <peff@peff.net>:

Show 12 quoted lines

> On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:
>
>> Add tests for new formatting atoms: rest, deltabase, objectsize:disk.
>> rest means nothing and we expand it into empty string.
>> We need this atom for cat-file command.
>> Have plans to support deltabase and objectsize:disk further
>> (as it is done in cat-file), now also expand it to empty string.
>
> I'm glad that you're adding tests, but I'm not sure it's a good idea to
> add tests checking for the thing we know to be wrong. If anything, you
> could be adding test_expect_failure looking for the _right_ thing, and
> accept that it does not yet work.

OK, I will try to fix that when other parts of the patch will look good enough. I am not sure at this point that we will add my code to the main version of the project, so these tests were written actually for checking current functionality better before sending the code for the review.

>
> -Peff