Re: [PATCH v3 04/23] ref-filter: make valid_atom as function parameter

From: Jeff King <peff@peff.net>
Date: Feb 15, 2018, 05:23 UTC
Message-ID: <20180215052312.GD18780@sigill.intra.peff.net>
In-Reply-To: <01020161890f4324-be5dda9b-9ad7-402f-9196-30f982fd20c2-000000@eu-west-1.amazonses.com>

On Mon, Feb 12, 2018 at 08:08:54AM +0000, Olga Telezhnaya wrote:

Show 9 quoted lines

> Make valid_atom as a function parameter,
> there could be another variable further.
> Need that for further reusing of formatting logic in cat-file.c.
> 
> We do not need to allow users to pass their own valid_atom variable in
> global functions like verify_ref_format() because in the end we want to
> have same set of valid atoms for all commands. But, as a first step
> of migrating, I create further another version of valid_atom
> for cat-file.

Hmm. So I see where you're going here, but I think in the end we'd want to have a single valid_atom list again, and we wouldn't need this.

And indeed, it looks like this goes away in patch 17. Can we reorganize/rebase the series so that we avoid dead-end directions like this?

-Peff