Re: [PATCH v5 10/13] xdiff: delete rchg aliasing

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 25, 2025, 22:02 UTC
Message-ID: <CAH=ZcbB8NOMLHqjCGYXFJ6Ms_zc3mMrDSPtargAJ1jcPE8fR7w@mail.gmail.com>
In-Reply-To: <xmqqh5wrhutd.fsf@gitster.g>

On Thu, Sep 25, 2025 at 1:09 AM Junio C Hamano <gitster@pobox.com> wrote:

Show 6 quoted lines

> So, with the same code but with a better justification like "the
> original uses a few local variables to shorten the code, but open
> coding the access to underlying members of nested structure without
> these local variables is not all that hard to read, so let's do so",
> would probably be an acceptable explanation with no need for other
> excuses, I would think.

I've changed my opinion. I'm going to drop this commit because I found myself using this design pattern in other functions, which would make me a hypocrite if this commit stays.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.