git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 15/17] xdiff: make xdfile_t.nrec a usize instead of long

From
Ezekiel Newren via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 7, 2025, 19:45 UTC
Message-ID
<0a180f69ff3cd4ac9efdee9546613df883cba9fe.1757274320.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.2048.git.git.1757274320.gitgitgadget@gmail.com>
From: Ezekiel Newren <ezekielnewren@gmail.com>
Signed-off-by: Ezekiel Newren <ezekielnewren@gmail.com>
---
 xdiff/xdiffi.c   |  8 ++++----
 xdiff/xemit.c    | 14 +++++++-------
 xdiff/xmerge.c   |  4 ++--
 xdiff/xprepare.c |  6 +++---
 xdiff/xtypes.h   |  2 +-
 5 files changed, 17 insertions(+), 17 deletions(-)
diff --git a/xdiff/xdiffi.c b/xdiff/xdiffi.c
index c8d351705c..ee72f5ea3b 100644
--- a/xdiff/xdiffi.c
+++ b/xdiff/xdiffi.c
@@ -483,7 +483,7 @@ static void measure_split(const xdfile_t *xdf, long split,
 {
 	long i;
 
-	if (split >= xdf->nrec) {
+	if (split >= (long)xdf->nrec) {
 		m->end_of_file = 1;
 		m->indent = -1;
 	} else {
@@ -506,7 +506,7 @@ static void measure_split(const xdfile_t *xdf, long split,
 
 	m->post_blank = 0;
 	m->post_indent = -1;
-	for (i = split + 1; i < xdf->nrec; i++) {
+	for (i = split + 1; i < (long)xdf->nrec; i++) {
 		m->post_indent = get_indent(&xdf->recs[i]);
 		if (m->post_indent != -1)
 			break;
@@ -717,7 +717,7 @@ static void group_init(xdfile_t *xdf, struct xdlgroup *g)
  */
 static inline int group_next(xdfile_t *xdf, struct xdlgroup *g)
 {
-	if (g->end == xdf->nrec)
+	if (g->end == (long)xdf->nrec)
 		return -1;
 
 	g->start = g->end + 1;
@@ -750,7 +750,7 @@ static inline int group_previous(xdfile_t *xdf, struct xdlgroup *g)
  */
 static int group_slide_down(xdfile_t *xdf, struct xdlgroup *g)
 {
-	if (g->end < xdf->nrec &&
+	if (g->end < (long)xdf->nrec &&
 	    recs_match(&xdf->recs[g->start], &xdf->recs[g->end])) {
 		xdf->rchg[g->start++] = NO;
 		xdf->rchg[g->end++] = YES;
diff --git a/xdiff/xemit.c b/xdiff/xemit.c
index ad3e859c57..aa63aab749 100644
--- a/xdiff/xemit.c
+++ b/xdiff/xemit.c
@@ -137,7 +137,7 @@ static long get_func_line(xdfenv_t *xe, xdemitconf_t const *xecfg,
 	buf = func_line ? func_line->buf : dummy;
 	size = func_line ? sizeof(func_line->buf) : sizeof(dummy);
 
-	for (l = start; l != limit && 0 <= l && l < xe->xdf1.nrec; l += step) {
+	for (l = start; l != limit && 0 <= l && l < (long)xe->xdf1.nrec; l += step) {
 		long len = match_func_rec(&xe->xdf1, xecfg, l, buf, size);
 		if (len >= 0) {
 			if (func_line)
@@ -179,14 +179,14 @@ pre_context_calculation:
 			long fs1, i1 = xch->i1;
 
 			/* Appended chunk? */
-			if (i1 >= xe->xdf1.nrec) {
+			if (i1 >= (long)xe->xdf1.nrec) {
 				long i2 = xch->i2;
 
 				/*
 				 * We don't need additional context if
 				 * a whole function was added.
 				 */
-				while (i2 < xe->xdf2.nrec) {
+				while (i2 < (long)xe->xdf2.nrec) {
 					if (is_func_rec(&xe->xdf2, xecfg, i2))
 						goto post_context_calculation;
 					i2++;
@@ -228,8 +228,8 @@ pre_context_calculation:
 
  post_context_calculation:
 		lctx = xecfg->ctxlen;
-		lctx = XDL_MIN(lctx, xe->xdf1.nrec - (xche->i1 + xche->chg1));
-		lctx = XDL_MIN(lctx, xe->xdf2.nrec - (xche->i2 + xche->chg2));
+		lctx = XDL_MIN(lctx, (long)xe->xdf1.nrec - (xche->i1 + xche->chg1));
+		lctx = XDL_MIN(lctx, (long)xe->xdf2.nrec - (xche->i2 + xche->chg2));
 
 		e1 = xche->i1 + xche->chg1 + lctx;
 		e2 = xche->i2 + xche->chg2 + lctx;
@@ -243,7 +243,7 @@ pre_context_calculation:
 			if (fe1 < 0)
 				fe1 = xe->xdf1.nrec;
 			if (fe1 > e1) {
-				e2 = XDL_MIN(e2 + (fe1 - e1), xe->xdf2.nrec);
+				e2 = XDL_MIN(e2 + (fe1 - e1), (long)xe->xdf2.nrec);
 				e1 = fe1;
 			}
 
@@ -254,7 +254,7 @@ pre_context_calculation:
 			 */
 			if (xche->next) {
 				long l = XDL_MIN(xche->next->i1,
-						 xe->xdf1.nrec - 1);
+						 (long)xe->xdf1.nrec - 1);
 				if (l - xecfg->ctxlen <= e1 ||
 				    get_func_line(xe, xecfg, NULL, l, e1) < 0) {
 					xche = xche->next;
diff --git a/xdiff/xmerge.c b/xdiff/xmerge.c
index c1a003326a..1ebcbb4e3a 100644
--- a/xdiff/xmerge.c
+++ b/xdiff/xmerge.c
@@ -158,7 +158,7 @@ static int is_eol_crlf(xdfile_t *file, int i)
 {
 	usize size;
 
-	if (i < file->nrec - 1)
+	if (i < (long)file->nrec - 1)
 		/* All lines before the last *must* end in LF */
 		return (size = file->recs[i].size) > 1 &&
 			file->recs[i].ptr[size - 2] == '\r';
@@ -622,7 +622,7 @@ static int xdl_do_merge(xdfenv_t *xe1, xdchange_t *xscr1,
 			changes = c;
 		i0 = xscr1->i1;
 		i1 = xscr1->i2;
-		i2 = xscr1->i1 + xe2->xdf2.nrec - xe2->xdf1.nrec;
+		i2 = xscr1->i1 + (long)xe2->xdf2.nrec - (long)xe2->xdf1.nrec;
 		chg0 = xscr1->chg1;
 		chg1 = xscr1->chg2;
 		chg2 = xscr1->chg1;
diff --git a/xdiff/xprepare.c b/xdiff/xprepare.c
index 9ec2a5d078..d990fe1c9e 100644
--- a/xdiff/xprepare.c
+++ b/xdiff/xprepare.c
@@ -153,7 +153,7 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_
 		for (top = blk + bsize; cur < top; ) {
 			prev = cur;
 			hav = xdl_hash_record(&cur, top, xpp->flags);
-			if (XDL_ALLOC_GROW(xdf->recs, xdf->nrec + 1, narec))
+			if (XDL_ALLOC_GROW(xdf->recs, (long)xdf->nrec + 1, narec))
 				goto abort;
 			crec = &xdf->recs[xdf->nrec++];
 			crec->ptr = (u8 const *)prev;
@@ -332,8 +332,8 @@ static int xdl_trim_ends(xdfile_t *xdf1, xdfile_t *xdf2) {
 		if (recs1->minimal_perfect_hash != recs2->minimal_perfect_hash)
 			break;
 
-	xdf1->dend = xdf1->nrec - i - 1;
-	xdf2->dend = xdf2->nrec - i - 1;
+	xdf1->dend = (long)xdf1->nrec - i - 1;
+	xdf2->dend = (long)xdf2->nrec - i - 1;
 
 	return 0;
 }
diff --git a/xdiff/xtypes.h b/xdiff/xtypes.h
index f2b53a6553..41986c6603 100644
--- a/xdiff/xtypes.h
+++ b/xdiff/xtypes.h
@@ -47,7 +47,7 @@ typedef struct s_xrecord {
 
 typedef struct s_xdfile {
 	xrecord_t *recs;
-	long nrec;
+	usize nrec;
 	long dstart, dend;
 	char *rchg;
 	long *rindex;
-- 
gitgitgadget
Previous: Ezekiel Newren via GitGitGadgetNext: Ezekiel Newren via GitGitGadget
Message 30 of 158 in “Use rust types in xdiff.”
  1. 00/17 Use rust types in xdiff.Ezekiel Newren via GitGitGadget, Sep 7, 2025
  2. 01/17 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 7, 2025
  3. Elijah NewrenSep 9, 2025
  4. 02/17 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 7, 2025
  5. Elijah NewrenSep 9, 2025
  6. 03/17 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 7, 2025
  7. Elijah NewrenSep 9, 2025
  8. 04/17 xdiff: delete xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 7, 2025
  9. Elijah NewrenSep 9, 2025
  10. 05/17 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 7, 2025
  11. Elijah NewrenSep 9, 2025
  12. 06/17 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 7, 2025
  13. Elijah NewrenSep 9, 2025
  14. 07/17 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 7, 2025
  15. Elijah NewrenSep 9, 2025
  16. 08/17 xdiff: delete chastore from xdfile_t, view with --color-wordsEzekiel Newren via GitGitGadget, Sep 7, 2025
  17. Elijah NewrenSep 9, 2025
  18. Phillip WoodSep 9, 2025
  19. Junio C HamanoSep 9, 2025
  20. Ben KnobleSep 10, 2025
  21. 09/17 xdiff: treat xdfile_t.rchg like an enumEzekiel Newren via GitGitGadget, Sep 7, 2025
  22. Elijah NewrenSep 9, 2025
  23. 10/17 compat/rust_types.h: define rust primitive typesEzekiel Newren via GitGitGadget, Sep 7, 2025
  24. Junio C HamanoSep 8, 2025
  25. Ezekiel NewrenSep 8, 2025
  26. 11/17 xdiff: include compat/rust_types.hEzekiel Newren via GitGitGadget, Sep 7, 2025
  27. 12/17 xdiff: make xrecord_t.ptr a u8 instead of charEzekiel Newren via GitGitGadget, Sep 7, 2025
  28. 13/17 xdiff: make xrecord_t.size a usize instead of longEzekiel Newren via GitGitGadget, Sep 7, 2025
  29. 14/17 xdiff: split xrecord_t.ha into line_hash and minimal_perfect_hashEzekiel Newren via GitGitGadget, Sep 7, 2025
  30. 15/17 xdiff: make xdfile_t.nrec a usize instead of longEzekiel Newren via GitGitGadget, Sep 7, 2025
  31. 16/17 xdiff: make xdfile_t.nreff a usize instead of longEzekiel Newren via GitGitGadget, Sep 7, 2025
  32. 17/17 xdiff: change the types of dstart, dend, rchg, and rindex in xdfile_tEzekiel Newren via GitGitGadget, Sep 7, 2025
  33. Junio C HamanoSep 16, 2025
  34. Ezekiel NewrenSep 16, 2025
  35. Elijah NewrenSep 17, 2025
  36. Junio C HamanoSep 17, 2025
  37. Junio C HamanoSep 17, 2025
  38. 00/10 Use rust types in xdiff.Ezekiel Newren via GitGitGadget, Sep 18, 2025
  39. 01/10 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 18, 2025
  40. 02/10 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 18, 2025
  41. 03/10 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 18, 2025
  42. 04/10 xdiff: delete xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 18, 2025
  43. 05/10 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 18, 2025
  44. 06/10 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 18, 2025
  45. 07/10 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 18, 2025
  46. 08/10 xdiff: delete chastore from xdfile_tEzekiel Newren via GitGitGadget, Sep 18, 2025
  47. 10/10 xdiff: treat xdfile_t.rchg like an enumEzekiel Newren via GitGitGadget, Sep 18, 2025
  48. Junio C HamanoSep 19, 2025
  49. Ezekiel NewrenSep 19, 2025
  50. Ezekiel NewrenSep 19, 2025
  51. 00/10 Cleanup xdfile_t and xrecord_t in xdiff.Ezekiel Newren via GitGitGadget, Sep 19, 2025
  52. 01/10 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 19, 2025
  53. Junio C HamanoSep 20, 2025
  54. Ezekiel NewrenSep 20, 2025
  55. Elijah NewrenSep 20, 2025
  56. Ben KnobleSep 20, 2025
  57. Junio C HamanoSep 20, 2025
  58. Ben KnobleSep 20, 2025
  59. Jeff KingSep 20, 2025
  60. Ben KnobleSep 20, 2025
  61. Junio C HamanoSep 20, 2025
  62. Jeff KingSep 20, 2025
  63. 02/10 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 19, 2025
  64. Junio C HamanoSep 20, 2025
  65. 03/10 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 19, 2025
  66. 04/10 xdiff: delete xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 19, 2025
  67. Junio C HamanoSep 20, 2025
  68. Phillip WoodSep 21, 2025
  69. Ezekiel NewrenSep 21, 2025
  70. 05/10 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 19, 2025
  71. Phillip WoodSep 21, 2025
  72. Ezekiel NewrenSep 21, 2025
  73. 06/10 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 19, 2025
  74. 07/10 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 19, 2025
  75. Phillip WoodSep 21, 2025
  76. Ezekiel NewrenSep 21, 2025
  77. 08/10 xdiff: delete chastore from xdfile_tEzekiel Newren via GitGitGadget, Sep 19, 2025
  78. 09/10 xdiff: delete rchg aliasingEzekiel Newren via GitGitGadget, Sep 19, 2025
  79. Phillip WoodSep 21, 2025
  80. Ezekiel NewrenSep 21, 2025
  81. 10/10 xdiff: treat xdfile_t.rchg like an enumEzekiel Newren via GitGitGadget, Sep 19, 2025
  82. Junio C HamanoSep 21, 2025
  83. Ezekiel NewrenSep 21, 2025
  84. Phillip WoodSep 21, 2025
  85. Ezekiel NewrenSep 21, 2025
  86. Elijah NewrenSep 19, 2025
  87. Ezekiel NewrenSep 19, 2025
  88. 00/12 Cleanup xdfile_t and xrecord_t in xdiff.Ezekiel Newren via GitGitGadget, Sep 22, 2025
  89. 01/12 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 22, 2025
  90. 02/12 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 22, 2025
  91. 03/12 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  92. 04/12 xdiff: delete superfluous function xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 22, 2025
  93. 05/12 xdiff: delete superfluous local variables that alias fields in xrecord_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  94. 06/12 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  95. 07/12 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 22, 2025
  96. 08/12 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  97. 09/12 xdiff: delete chastore from xdfile_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  98. 10/12 xdiff: delete rchg aliasingEzekiel Newren via GitGitGadget, Sep 22, 2025
  99. 11/12 xdiff: use bool literals for xdfile_t.rchgEzekiel Newren via GitGitGadget, Sep 22, 2025
  100. 12/12 xdiff: refactor 'char *rchg' to 'bool *changed' in xdfile_tEzekiel Newren via GitGitGadget, Sep 22, 2025
  101. Junio C HamanoSep 22, 2025
  102. Ezekiel NewrenSep 23, 2025
  103. Junio C HamanoSep 23, 2025
  104. Ezekiel NewrenSep 23, 2025
  105. Junio C HamanoSep 23, 2025
  106. Ezekiel NewrenSep 23, 2025
  107. 00/13 Cleanup xdfile_t and xrecord_t in xdiff.Ezekiel Newren via GitGitGadget, Sep 23, 2025
  108. 01/13 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 23, 2025
  109. 02/13 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 23, 2025
  110. 03/13 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  111. 04/13 xdiff: delete superfluous function xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 23, 2025
  112. Kristoffer HaugsbakkSep 30, 2025
  113. Ezekiel NewrenSep 30, 2025
  114. Junio C HamanoSep 30, 2025
  115. 05/13 xdiff: delete superfluous local variables that alias fields in xrecord_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  116. Phillip WoodSep 24, 2025
  117. Ezekiel NewrenSep 24, 2025
  118. 06/13 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  119. 07/13 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 23, 2025
  120. 08/13 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  121. 09/13 xdiff: delete chastore from xdfile_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  122. 10/13 xdiff: delete rchg aliasingEzekiel Newren via GitGitGadget, Sep 23, 2025
  123. Phillip WoodSep 24, 2025
  124. Ezekiel NewrenSep 24, 2025
  125. Junio C HamanoSep 24, 2025
  126. Ezekiel NewrenSep 24, 2025
  127. Junio C HamanoSep 24, 2025
  128. Ezekiel NewrenSep 24, 2025
  129. Junio C HamanoSep 25, 2025
  130. Ezekiel NewrenSep 25, 2025
  131. 11/13 xdiff: rename rchg -> changed in xdfile_tEzekiel Newren via GitGitGadget, Sep 23, 2025
  132. Phillip WoodSep 24, 2025
  133. Ezekiel NewrenSep 24, 2025
  134. Phillip WoodSep 24, 2025
  135. 12/13 xdiff: use enum macros NONE(0), SOME(1), TOO_MANY(2) in xprepare.cEzekiel Newren via GitGitGadget, Sep 23, 2025
  136. Phillip WoodSep 24, 2025
  137. Ezekiel NewrenSep 24, 2025
  138. Phillip WoodSep 24, 2025
  139. Junio C HamanoSep 24, 2025
  140. Ezekiel NewrenSep 25, 2025
  141. Ezekiel NewrenSep 26, 2025
  142. 13/13 xdiff: change type of xdfile_t.changed from char to boolEzekiel Newren via GitGitGadget, Sep 23, 2025
  143. Phillip WoodSep 24, 2025
  144. Ezekiel NewrenSep 24, 2025
  145. 00/12 Cleanup xdfile_t and xrecord_t in xdiff.Ezekiel Newren via GitGitGadget, Sep 26, 2025
  146. 01/12 xdiff: delete static forward declarations in xprepareEzekiel Newren via GitGitGadget, Sep 26, 2025
  147. 02/12 xdiff: delete local variables and initialize/free xdfile_t directlyEzekiel Newren via GitGitGadget, Sep 26, 2025
  148. 03/12 xdiff: delete unnecessary fields from xrecord_t and xdfile_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  149. 04/12 xdiff: delete superfluous function xdl_get_rec() in xemitEzekiel Newren via GitGitGadget, Sep 26, 2025
  150. 05/12 xdiff: delete local variables that alias fields in xrecord_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  151. 06/12 xdiff: delete struct diffdata_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  152. 07/12 xdiff: delete redundant array xdfile_t.haEzekiel Newren via GitGitGadget, Sep 26, 2025
  153. 08/12 xdiff: delete fields ha, line, size in xdlclass_t in favor of an xrecord_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  154. 09/12 xdiff: delete chastore from xdfile_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  155. 10/12 xdiff: rename rchg -> changed in xdfile_tEzekiel Newren via GitGitGadget, Sep 26, 2025
  156. 11/12 xdiff: add macros DISCARD(0), KEEP(1), INVESTIGATE(2) in xprepare.cEzekiel Newren via GitGitGadget, Sep 26, 2025
  157. 12/12 xdiff: change type of xdfile_t.changed from char to boolEzekiel Newren via GitGitGadget, Sep 26, 2025
  158. Phillip WoodOct 3, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.