Re: [PATCH v3 01/10] xdiff: delete static forward declarations in xprepare

From: Ben Knoble <ben.knoble@gmail.com>
Date: Sep 20, 2025, 17:46 UTC
Message-ID: <83F61517-06DB-402E-911A-E33EE07D54AE@gmail.com>
In-Reply-To: <xmqqh5wxxcwq.fsf@gitster.g>

Show 14 quoted lines

> Le 20 sept. 2025 à 13:16, Junio C Hamano <gitster@pobox.com> a écrit :
> 
> "Ezekiel Newren via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> From: Ezekiel Newren <ezekielnewren@gmail.com>
>> 
>> Move xdl_prepare_env() later in the file to avoid the need
>> for static forward declarations.
>> 
>> Best-viewed-with: --color-moved
> 
> Two comments.
> 
> - This is a bit unusual to see in the trailer.

This was (loosely!) my suggestion, and I think Peff has once or twice done something similar.

No harm in working it into the prose instead, and I have no stake either way beyond a mild personal preference for the trailer.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.