Re: [PATCH v5 04/13] xdiff: delete superfluous function xdl_get_rec() in xemit

From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Sep 30, 2025, 19:35 UTC
Message-ID: <CAH=ZcbDjFh0wtWyU_1x-GCgzt3a0xUye+RU-LY-9rMBtVoSnTA@mail.gmail.com>
In-Reply-To: <db85429d-2c89-43ec-a92e-96ad8d0049ce@app.fastmail.com>

On Tue, Sep 30, 2025 at 7:31 AM Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com> wrote:

Show 5 quoted lines

> > When xrecord_t was a linked list, and recs didn't exist, I assume this
> > function walked the list until it found the right record. Accessing
> > a contiguous array is so trival that this function is now superfluous.
>
> s/trival/trivial/

I think that other than this typo this patch series is ready to be merged in. I would prefer that Junio fix this typo, so I don't spam the mailing list with such a small change.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.