From: Ezekiel Newren <ezekielnewren@gmail.com>
Date: Thu, 25 Sep 2025 22:02:33 GMT
Subject: Re: [PATCH v5 10/13] xdiff: delete rchg aliasing
Message-ID: <CAH=ZcbB8NOMLHqjCGYXFJ6Ms_zc3mMrDSPtargAJ1jcPE8fR7w@mail.gmail.com>
In-Reply-To: <xmqqh5wrhutd.fsf@gitster.g>

On Thu, Sep 25, 2025 at 1:09 AM Junio C Hamano <gitster@pobox.com> wrote:
> So, with the same code but with a better justification like "the
> original uses a few local variables to shorten the code, but open
> coding the access to underlying members of nested structure without
> these local variables is not all that hard to read, so let's do so",
> would probably be an acceptable explanation with no need for other
> excuses, I would think.

I've changed my opinion. I'm going to drop this commit because I found
myself using this design pattern in other functions, which would make
me a hypocrite if this commit stays.