Re: [PATCH v4 00/12] Cleanup xdfile_t and xrecord_t in xdiff.

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 23, 2025, 14:12 UTC
Message-ID: <xmqqa52lqmup.fsf@gitster.g>
In-Reply-To: <CAH=ZcbAHgCLjpLMzditOg8CW-L1RPohGuQjst=h-rATTSoio3Q@mail.gmail.com>

Ezekiel Newren <ezekielnewren@gmail.com> writes:

> I apologize for my previous phrasing. I was not very tactful. Yes, I
> think your suggestion is a good idea. I'll incorporate that into my
> patches.

I didn't get an impression that you were _not_ tactful at all. If the arrangement is like what I outlined in the message you are responding to, I am perfectly fine if the type of changed[] is an array of bool. The only thing I found was disturbing was the idea to assign 2 into a _Bool. Comparing a _Bool, which can be either 0 oor 1, and find it is different from litral 2 (or MAYBE that is defined to be 2) is perfectly fine.

Thanks.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.