Re: [PATCH 08/17] xdiff: delete chastore from xdfile_t, view with --color-words

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 9, 2025, 20:33 UTC
Message-ID: <xmqqwm67tlg9.fsf@gitster.g>
In-Reply-To: <CABPp-BHdKu2nsWhpfGY4MexfChxfwv_0mqvpgrV3kbYgdCYKEg@mail.gmail.com>

Elijah Newren <newren@gmail.com> writes:

Show 8 quoted lines

> On Sun, Sep 7, 2025 at 12:46 PM Ezekiel Newren via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
>>
>> From: Ezekiel Newren <ezekielnewren@gmail.com>
>
> My personal bias is that things like "view with --color-words" makes
> more sense to include near the end of the commit message, just before
> the sign-offs.  Not sure if others agree on that.

FWIW, I am with you. Certainly not on the title. It is even fine immediately below the three-dash line before the diffstat.

Thanks. I am enjoying to follow along the series by reading your reviews.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.