From: Stefan Beller Date: Tue, 26 May 2015 22:20:25 GMT Subject: Re: [RFC/WIP PATCH 02/11] upload-pack: only accept capabilities on the first "want" line Message-ID: In-Reply-To: On Tue, May 26, 2015 at 3:17 PM, Junio C Hamano wrote: > Stefan Beller writes: > >> From: Nguyễn Thái Ngọc Duy >> >> pack-protocol.txt says so and fetch-pack also follows it even though >> upload-pack is a bit lax. Fix it. > > Hmm, I actually think the .txt file unsuccessfully tried to close > the barn door after horse has long left. The existing clients that > read protocol capabilities keep the last-read copy and then > overwrite it when a new one came, which is why we couldn't update > the protocol by sending only incremental changes, etc. without > breaking existing clients. On the other hand I am not aware of any remote implementation handing out capabilities after the first line, so this would not break anything to my knowledge. > > I somehow thought that we already discussed why this was bad the > first time Duy's patch was posted, but apparently we didn't. /me checks the archive. I may have overlooked that part. :( > > X-<.