Re: Re: [GSoC][Patch]

From: Harshit Jain <harshitjain1371999@gmail.com>
Date: Mar 20, 2020, 17:14 UTC
Message-ID: <CACuU+s-s2zMJq5xymyTz45AVyT0gL1sgcpk3rUcA-Bp-D+F=2g@mail.gmail.com>
In-Reply-To: <20200320155604.7854-1-shouryashukla.oo@gmail.com>

Hi Shourya,

On Fri, Mar 20, 2020 at 9:26 PM Shourya Shukla <shouryashukla.oo@gmail.com> wrote:

Show 17 quoted lines

>
> Hello Harshit,
>
> > The tests in t4131 leave a space character between the redirection operator
> > and the file i.e. the redirection target which does not conform to the
> > modern coding style.
>
> > Fix them.
>
> I think something like,
>
> The tests in t4131 were written a long time ago and hence contain style violations
> such as an extra space between the redirection operator(>) and the redirection target.
> Update it to match the latest CodingGuidelines.
>
> may be better.
>

Please see the comment made by Junio Hamano, pasted below:

"written a long time ago" does not have much value by itself (it does serve as a backstory to explain a half of why it does not use the more modern style, though). "have a few style violations." is almost meaningless (otherwise, you would not be doing a "modernize style" patch in the first place ;-).

I myself also agree with the above comment and hence, wrote the commit message accordingly. What do you think?

Show 8 quoted lines

> Also, when you deliver a newer version of the patch, i.e., version 2 in your case,
> you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and
> hence avoid confusion.
>
> If you are using 'git format-patch' to formulate your mails, you can do:
>
> 'git format-patch -v2 <..>' to get a v2 based mail.
>

Oh nice, didn't know about this. I will keep this in mind for future patch submissions. Should I do this for the current patch as well?

Regards, Harshit Jain