git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>

From
Kaartic Sivaraam <kaartic.sivaraam@gmail.com>
Date
Mar 19, 2020, 17:33 UTC
Message-ID
<555da203-0740-3d79-15cf-83c5a8d5dbae@gmail.com>
In-Reply-To
<20200319164234.4441-1-shouryashukla.oo@gmail.com>
On 19-03-2020 22:12, Shourya Shukla wrote:
Show 12 quoted lines
> Hello Harshit,
> 
>> Replace 'test -f' with the helper function 'test_path_is_file' as the helper function improves the code readability and also gives better error messages.
> 
> Again the same thing, you may follow what I stated before regarding commit messages.
> 
> The commit title can be of the form:
> 
> t4131: use helpers to replace test -f <path>
> 
> <<commit description>>
>

Just curious, isn't the commit title already like that in this patch? The subject does read:

   [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>"
What am I missing?
-- 
Sivaraam
Previous: Shourya ShuklaNext: Harshit Jain
Message 8 of 17 in “t4131: update test script”
  1. Harshit JainMar 19, 2020
  2. [GSoC][PATCH 1/2] t4131: modernize styleHarshit Jain, Mar 19, 2020
  3. Shourya ShuklaMar 19, 2020
  4. Harshit JainMar 19, 2020
  5. Junio C HamanoMar 19, 2020
  6. [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>Harshit Jain, Mar 19, 2020
  7. Shourya ShuklaMar 19, 2020
  8. Kaartic SivaraamMar 19, 2020
  9. Harshit JainMar 19, 2020
  10. Shourya ShuklaMar 20, 2020
  11. Junio C HamanoMar 19, 2020
  12. [GSoC][Patch 0/2] made the changes as per community suggestionsHarshit Jain, Mar 20, 2020
  13. 1/2 t4131: modernize styleHarshit Jain, Mar 20, 2020
  14. Shourya ShuklaMar 20, 2020
  15. Harshit JainMar 20, 2020
  16. 2/2 t4131: use helper function to replace 'test -f'Harshit Jain, Mar 20, 2020
  17. Shourya ShuklaMar 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.