git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Re: [GSoC][Patch]

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Mar 20, 2020, 15:56 UTC
Message-ID
<20200320155604.7854-1-shouryashukla.oo@gmail.com>
In-Reply-To
<20200320130845.23257-2-harshitjain1371999@gmail.com>
Hello Harshit,
> The tests in t4131 leave a space character between the redirection operator
> and the file i.e. the redirection target which does not conform to the
> modern coding style.
> Fix them.
I think something like,

The tests in t4131 were written a long time ago and hence contain style violations such as an extra space between the redirection operator(>) and the redirection target. Update it to match the latest CodingGuidelines.

may be better.

Also, when you deliver a newer version of the patch, i.e., version 2 in your case, you have a [PATCH v2 1/n] as the subject, so that people know that it is the v2 and hence avoid confusion.

If you are using 'git format-patch' to formulate your mails, you can do:
'git format-patch -v2 <..>' to get a v2 based mail.

Regards, Shourya Shukla

Previous: Harshit JainNext: Harshit Jain
Message 14 of 17 in “t4131: update test script”
  1. Harshit JainMar 19, 2020
  2. [GSoC][PATCH 1/2] t4131: modernize styleHarshit Jain, Mar 19, 2020
  3. Shourya ShuklaMar 19, 2020
  4. Harshit JainMar 19, 2020
  5. Junio C HamanoMar 19, 2020
  6. [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>Harshit Jain, Mar 19, 2020
  7. Shourya ShuklaMar 19, 2020
  8. Kaartic SivaraamMar 19, 2020
  9. Harshit JainMar 19, 2020
  10. Shourya ShuklaMar 20, 2020
  11. Junio C HamanoMar 19, 2020
  12. [GSoC][Patch 0/2] made the changes as per community suggestionsHarshit Jain, Mar 20, 2020
  13. 1/2 t4131: modernize styleHarshit Jain, Mar 20, 2020
  14. Shourya ShuklaMar 20, 2020
  15. Harshit JainMar 20, 2020
  16. 2/2 t4131: use helper function to replace 'test -f'Harshit Jain, Mar 20, 2020
  17. Shourya ShuklaMar 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.