git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC][PATCH 1/2] t4131: modernize style

From
Shourya Shukla <shouryashukla.oo@gmail.com>
Date
Mar 19, 2020, 16:38 UTC
Message-ID
<20200319163817.4239-1-shouryashukla.oo@gmail.com>
In-Reply-To
<20200319132957.17813-2-harshitjain1371999@gmail.com>
Hello Harshit,
> The tests in 't4131-apply-fake-ancestor.sh' were written a long time ago, and have a few style violations. Update it to adhere to the CodingGuidelines.

Maybe add a commit title and then have a body? To do so, do a 'git commit' instead of 'git commit -m "message"'. This will open a text editor in which you can edit your commit message. You may refer to this answer I gave on StackOverflow on commit messages:

https://stackoverflow.com/a/60755299/10751129

Also, commit messages are generally around 72 characters per line. What are the style violations you are talking about BTW?

The commit title can be of the form:
t4131: modernise style
<<commit description>>

Regards, Shourya Shukla

Previous: Harshit JainNext: Harshit Jain
Message 3 of 17 in “t4131: update test script”
  1. Harshit JainMar 19, 2020
  2. [GSoC][PATCH 1/2] t4131: modernize styleHarshit Jain, Mar 19, 2020
  3. Shourya ShuklaMar 19, 2020
  4. Harshit JainMar 19, 2020
  5. Junio C HamanoMar 19, 2020
  6. [GSoC][PATCH 2/2] t4131: use helper function to replace test -f <path>Harshit Jain, Mar 19, 2020
  7. Shourya ShuklaMar 19, 2020
  8. Kaartic SivaraamMar 19, 2020
  9. Harshit JainMar 19, 2020
  10. Shourya ShuklaMar 20, 2020
  11. Junio C HamanoMar 19, 2020
  12. [GSoC][Patch 0/2] made the changes as per community suggestionsHarshit Jain, Mar 20, 2020
  13. 1/2 t4131: modernize styleHarshit Jain, Mar 20, 2020
  14. Shourya ShuklaMar 20, 2020
  15. Harshit JainMar 20, 2020
  16. 2/2 t4131: use helper function to replace 'test -f'Harshit Jain, Mar 20, 2020
  17. Shourya ShuklaMar 20, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.