Re: [PATCH v7 10/13] pack-objects: clarify the use of object_entry::size

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 31, 2018, 04:35 UTC
Message-ID: <CACsJy8AQ7yRK65rYqMkR+QJn2KUJ=Y+9E_=k3aBU78xF=LBQjw@mail.gmail.com>
In-Reply-To: <20180330210416.GH14782@sigill.intra.peff.net>

On Fri, Mar 30, 2018 at 11:04 PM, Jeff King <peff@peff.net> wrote:

> The subject says "clarify" so I was a little surprised to see code
> changes. It looks like we're just avoiding reassigning on top of the
> value repeatedly, which is part of that clarification. It looks like a
> noop to me.

Oh well... I was counting on the new name (in_pack_size, which follows in_pack_type naming convention) to emphasize it (and the new "delta size" comment to point out where in_pack_size contains a delta size.

-- 
Duy

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.