Re: [PATCH v7 06/13] pack-objects: move in_pack out of struct object_entry

From: Duy Nguyen <pclouds@gmail.com>
Date: Mar 24, 2018, 12:26 UTC
Message-ID: <CACsJy8B=TYTOu=4i0+0bqHRMDfJCQW5JA=3-g+v=D6pi2dbULw@mail.gmail.com>
In-Reply-To: <87efk9yfm2.fsf@evledraar.gmail.com>

On Sat, Mar 24, 2018 at 10:42 AM, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

Show 19 quoted lines

>
> On Sat, Mar 24 2018, Nguyễn Thái Ngọc Duy wrote:
>
>> +     if (pack->in_pack_by_idx) {
>> +             if (p->index <= 0)
>> +                     die("BUG: found_pack should be NULL "
>> +                                     "instead of having non-positive index");
>> +                     e->in_pack_idx = p->index;
>> +     } else
>
> The indentation after the die() here is wrong. GCC complaining about it:
>
>     ./pack-objects.h: In function ‘oe_set_in_pack’:
>     ./pack-objects.h:203:3: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
>        if (p->index <= 0)
>        ^~
>     ./pack-objects.h:206:4: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
>         e->in_pack_idx = p->index;
>         ^

Thanks. My gcc reported the same thing but only when not used with ccache, hm...

-- 
Duy