Re: [PATCH v6 09/11] pack-objects: shrink size field in struct object_entry
- From
Jeff King <peff@peff.net>
- Date
- Mar 21, 2018, 08:03 UTC
- Message-ID
- <20180321080343.GA25537@sigill.intra.peff.net>
- In-Reply-To
- <20180320180806.GA16521@duynguyen.home>
On Tue, Mar 20, 2018 at 07:08:07PM +0100, Duy Nguyen wrote:
Show 23 quoted lines
> BTW can you apply this patch? This broken && chain made me think the > problem was in the next test. It would have saved me lots of time if I > saw this "BUG" line coming from the previous test. > > -- 8< -- > Subject: [PATCH] t9300: fix broken && chain > > Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> > --- > t/t9300-fast-import.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh > index e4d06accc4..e2a0ae4075 100755 > --- a/t/t9300-fast-import.sh > +++ b/t/t9300-fast-import.sh > @@ -348,7 +348,7 @@ test_expect_success 'B: accept branch name "TEMP_TAG"' ' > INPUT_END > > test_when_finished "rm -f .git/TEMP_TAG > - git gc > + git gc && > git prune" &&
The &&-chain is broken from the first command, too. It's "rm -f", which is not that big a deal, but...
Show 7 quoted lines
> @@ -365,7 +365,7 @@ test_expect_success 'B: accept empty committer' ' > INPUT_END > > test_when_finished "git update-ref -d refs/heads/empty-committer-1 > - git gc > + git gc && > git prune" &&
Same here, but we probably care more about noticing update-ref failure.
-Peff