Re: [PATCH 09/11] pack-objects: refer to delta objects by index instead of pointer

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 1, 2018, 18:08 UTC
Message-ID: <xmqqvaefhdoc.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180301091052.32267-10-pclouds@gmail.com>

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

Show 6 quoted lines

> Notice that packing_data::nr_objects is uint32_t, we could only handle
> maximum 4G objects and can address all of them with an uint32_t. If we
> use a pointer here, we waste 4 bytes on 64 bit architecture.
>
> Convert these delta pointers to indexes. Since we need to handle NULL
> pointers as well, the index is shifted by one [1].

Makes perfect sense.

I do not think losing 1 slot out of possible 4G is a regression, unlike the 256 packfile limit 07/11 imposes.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.