Re: [PATCH v3 2/7] gc: add --keep-base-pack

From: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Date: Mar 16, 2018, 21:05 UTC
Message-ID: <87zi37d93w.fsf@evledraar.gmail.com>
In-Reply-To: <20180316192745.19557-3-pclouds@gmail.com>

On Fri, Mar 16 2018, Nguyễn Thái Ngọc Duy jotted:

Show 5 quoted lines

> +--keep-base-pack::
> +	All packs except the base pack and those marked with a `.keep`
> +	files are consolidated into a single pack. The largest pack is
> +	considered the base pack.
> +

I wonder if all of this would be less confusing as:

> +--keep-biggest-pack::
> +	All packs except the largest pack and those marked with a `.keep`
> +	files are consolidated into a single pack.

I.e. just skimming these docs I'd expect "base" to somehow be the thing that we initially cloned, of course in almost all cases that *is* the largest pack, but not necessarily. So rather than communicate that expectation let's just say largest/biggest?

Maybe I'm the only one who finds this confusing...