Re: [PATCH 0/4] t: replace incorrect test_must_fail usage (part 5)

From

Johannes Sixt <j6t@kdbg.org>

Date

Apr 29, 2020, 21:30 UTC

Message-ID

<90edb162-e035-bdb7-a2d2-ffc6bd075977@kdbg.org>

In-Reply-To

<20200429195035.GB3920@syl.local>

Am 29.04.20 um 21:50 schrieb Taylor Blau:

> This comment has nothing to do with your series, but I am curious if you
> are planning on touching 'test_might_fail' at all. These can be useful
> for non-Git commands, too, such as 'test_might_fail umask 022' on
> systems that may or may not do something sensible with umask.

When it's not a git command that might fail, the idiom is

	... &&
	{ umask 022 || :; } &&
	...

-- Hannes