Re: Re* [PATCH 0/4] t: replace incorrect test_must_fail usage (part 5)

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 29, 2020, 22:10 UTC
Message-ID: <xmqqy2qet02d.fsf@gitster.c.googlers.com>
In-Reply-To: <20200429214906.GA12075@syl.local>

Taylor Blau <me@ttaylorr.com> writes:

> To me this seems a little overkill, but it may not be on environments
> where an extra subshell incurred by 'test_might_fail' might be overly
> expensive.

It comes from the same principle as "we are not in the business of catching segv from system tools---don't use test_must_fail on non-git commands". Adopting the convention happened quite some time ago and that was why I checked if we failed to document it.

What I wondered was if it is overkill to document the convention; if the convention was overkill is not a question at this point.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.