Re: [PATCH 0/4] t: replace incorrect test_must_fail usage (part 5)

From: Taylor Blau <me@ttaylorr.com>
Date: Apr 29, 2020, 19:50 UTC
Message-ID: <20200429195035.GB3920@syl.local>
In-Reply-To: <cover.1588162842.git.liu.denton@gmail.com>

On Wed, Apr 29, 2020 at 08:22:22AM -0400, Denton Liu wrote:

Show 5 quoted lines

> The overall scope of these patches is to replace inappropriate uses of
> test_must_fail. IOW, we should only allow test_must_fail to run on `git`
> and `test-tool`. Ultimately, we will conclude by making test_must_fail
> error out on non-git commands. An advance view of the final series can
> be found here[1].

This comment has nothing to do with your series, but I am curious if you are planning on touching 'test_might_fail' at all. These can be useful for non-Git commands, too, such as 'test_might_fail umask 022' on systems that may or may not do something sensible with umask.

Sorry for injecting myself into this thread on an otherwise unrelated topic.

Thanks, Taylor