Re: [PATCH 1/8] Use %B for Split Subject/Body
- From
greened@obbligato.org <greened@obbligato.org>
- Date
- Jan 1, 2013, 22:29 UTC
- Message-ID
- <87wqvwfsfm.fsf@waller.obbligato.org>
- In-Reply-To
- <7va9ssa94l.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 6 quoted lines
> "David A. Greene" <greened@obbligato.org> writes: > >> Subject: Re: [PATCH 1/8] Use %B for Split Subject/Body > > This needs to say "contrib/subtree" somewhere (applies to all > patches in this series).
Ok. Shall I re-send everything?
Show 8 quoted lines
>> From: Techlive Zheng <techlivezheng@gmail.com> >> >> Use %B to format the commit message and body to avoid an extra newline >> if a commit only has a subject line. >> >> Author: Techlive Zheng <techlivezheng@gmail.com> > > This needs to be a S-o-b instead; is it a real name, by the way?
Ok. No idea about the name but his online presence seems consistent at least.
Show 6 quoted lines
>> +# Save this hash for testing later. >> + >> +subdir_hash=`git rev-parse HEAD` >> + > > We prefer $() over ``; much more readable.
Ack, of course. I don't know how I missed that.
Show 5 quoted lines
>> # 15 >> test_expect_success 'add main6' ' >> create main6 && > > Why?
It was in the original testsuite from Avery. I didn't add or remove any tests when I first integrated git-subtree.
Show 5 quoted lines
>> @@ -235,7 +238,19 @@ test_expect_success 'check split with --branch' ' >> check_equal ''"$(git rev-parse splitbr1)"'' "$spl1" > > Is quoting screwed up around here (and in many other places in this > patch)? What are these no-op '' doing?
I assumed they are there to get the double-quotes around the command. I'll see about removing them.
>> -# 25 >> +#25 > > Why the lossage of a SP?
I think this got fixed later in the series.
> It may make sense to lose these "# num" that will have to be touched > every time somebody inserts new test pieces in the middle, as a > preparatory step before any of these patches, by the way. That will > reduce noise in the patches for real changes.
Yeah, I know, but it makes it really easy to find a test when something goes wrong.
-David