Re: [PATCH 5/8] Honor DESTDIR

From: greened@obbligato.org <greened@obbligato.org>
Date: Jan 1, 2013, 22:36 UTC
Message-ID: <87fw2kfs3i.fsf@waller.obbligato.org>
In-Reply-To: <7vsj6k8tr8.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 16 quoted lines

> "David A. Greene" <greened@obbligato.org> writes:
>
>> From: Adam Tkac <atkac@redhat.com>
>>
>> Teach git-subtree's Makefile to honor DESTDIR.
>>
>> Author:    Adam Tkac <atkac@redhat.com>
>>
>> Signed-off-by:    Adam Tkac <atkac@redhat.com>
>>
>> Signed-off-by: David A. Greene <greened@obbligato.org>
>> ---
>
> The contents of the patch looks sensible; the above is questionable
> as all the other messages in this series, though.  Did any of our
> tools cause this failure?  If so I would like to know more about it.

What failure are you referring to? When I used git send-email --author, the Author: line was commented out. I assumed I was supposed to uncomment it. Guess I was wrong.

I'll re-send the series since you pointed out a number of improvements.

                       -David