Re: [PATCH 1/8] Use %B for Split Subject/Body

From: greened@obbligato.org <greened@obbligato.org>
Date: Jan 1, 2013, 22:24 UTC
Message-ID: <877gnwh781.fsf@waller.obbligato.org>
In-Reply-To: <7vtxr1bg4g.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 10 quoted lines

> "David A. Greene" <greened@obbligato.org> writes:
>
>> From: Techlive Zheng <techlivezheng@gmail.com>
>>
>> Use %B to format the commit message and body to avoid an extra newline
>> if a commit only has a subject line.
>
> Is this an unconditional improvement, or is it generally an
> improvement but for some users it may be a regression?  I am
> guessing it is the former but am just making sure.

The former.

Show 6 quoted lines

>> Author:    Techlive Zheng <techlivezheng@gmail.com>
>>
>> Signed-off-by: David A. Greene <greened@obbligato.org>
>
> Please don't do "Author: " which does not add anything new.  That is
> what "From: " is for.  Instead it needs to be a sign-off.

Ok. Unfortunately I sent a number of patches like that. Do you want me to re-send them?

> Also, is that a real name, I have to wonder?

No idea.  Not likely, I'd say.

                        -David