Re: [PATCH 5/8] Honor DESTDIR

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 1, 2013, 21:42 UTC
Message-ID: <7vsj6k8tr8.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1357012655-24974-6-git-send-email-greened@obbligato.org>

"David A. Greene" <greened@obbligato.org> writes:

Show 10 quoted lines

> From: Adam Tkac <atkac@redhat.com>
>
> Teach git-subtree's Makefile to honor DESTDIR.
>
> Author:    Adam Tkac <atkac@redhat.com>
>
> Signed-off-by:    Adam Tkac <atkac@redhat.com>
>
> Signed-off-by: David A. Greene <greened@obbligato.org>
> ---

The contents of the patch looks sensible; the above is questionable as all the other messages in this series, though. Did any of our tools cause this failure? If so I would like to know more about it.

Show 22 quoted lines

>  contrib/subtree/Makefile |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index 05cdd5c..36ae3e4 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -30,12 +30,12 @@ $(GIT_SUBTREE): $(GIT_SUBTREE_SH)
>  doc: $(GIT_SUBTREE_DOC)
>  
>  install: $(GIT_SUBTREE)
> -	$(INSTALL) -m 755 $(GIT_SUBTREE) $(libexecdir)
> +	$(INSTALL) -m 755 $(GIT_SUBTREE) $(DESTDIR)$(libexecdir)
>  
>  install-doc: install-man
>  
>  install-man: $(GIT_SUBTREE_DOC)
> -	$(INSTALL) -m 644 $^ $(man1dir)
> +	$(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)
>  
>  $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)
>  	xmlto -m $(MANPAGE_NORMAL_XSL)  man $^