Re: [PATCH 6/8] Make the Manual Directory if Needed

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 1, 2013, 21:44 UTC
Message-ID: <7vobh88tp3.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1357012655-24974-7-git-send-email-greened@obbligato.org>

"David A. Greene" <greened@obbligato.org> writes:

Show 23 quoted lines

> From: "Jesper L. Nielsen" <lyager@gmail.com>
>
> Before install git-subtree documentation, make sure the manpage
> directory exists.
>
> Author:    Jesper L. Nielsen <lyager@gmail.com>
>
> Signed-off-by:    Jesper L. Nielsen <lyager@gmail.com>
>
> Signed-off-by: David A. Greene <greened@obbligato.org>
> ---
>  contrib/subtree/Makefile |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile
> index 36ae3e4..52d6fb9 100644
> --- a/contrib/subtree/Makefile
> +++ b/contrib/subtree/Makefile
> @@ -35,6 +35,7 @@ install: $(GIT_SUBTREE)
>  install-doc: install-man
>  
>  install-man: $(GIT_SUBTREE_DOC)
> +	mkdir -p $(man1dir)

We seem to use "$(INSTALL) -d -m 755" for this kind of thing (see the Documentation/Makefile).

>  	$(INSTALL) -m 644 $^ $(DESTDIR)$(man1dir)
>  
>  $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)