Re: [PATCH 1/8] Use %B for Split Subject/Body

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 2, 2013, 00:30 UTC
Message-ID: <7vehi477er.fsf@alter.siamese.dyndns.org>
In-Reply-To: <87wqvwfsfm.fsf@waller.obbligato.org>

greened@obbligato.org writes:

Show 10 quoted lines

> Ack, of course.  I don't know how I missed that.
>
>>>  # 15
>>>  test_expect_success 'add main6' '
>>>          create main6 &&
>>
>> Why?
>
> It was in the original testsuite from Avery.  I didn't add or remove any
> tests when I first integrated git-subtree.

The question was about the lossage of the blank line, which does not seem to be related to what this patch wants to do.

Show 6 quoted lines

>>> -# 25
>>> +#25
>>
>> Why the lossage of a SP?
>
> I think this got fixed later in the series.

That is not a good excuse to introduce breakages in the first place, no?

Show 7 quoted lines

>> It may make sense to lose these "# num" that will have to be touched
>> every time somebody inserts new test pieces in the middle, as a
>> preparatory step before any of these patches, by the way.  That will
>> reduce noise in the patches for real changes.
>
> Yeah, I know, but it makes it really easy to find a test when something
> goes wrong.

That is what "tXXXX-*.sh -i" is for, isn't it?