Re: [PATCH 2/8] Add --unannotate

From: greened@obbligato.org <greened@obbligato.org>
Date: Jan 1, 2013, 22:31 UTC
Message-ID: <87sj6kfsbz.fsf@waller.obbligato.org>
In-Reply-To: <7v623ga8vs.fsf@alter.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> writes:

Show 12 quoted lines

> "David A. Greene" <greened@obbligato.org> writes:
>
>> From: James Nylen <jnylen@gmail.com>
>>
>> Teach git-subtree about --unannotate.  This option strips a prefix
>> from a commit message when doing a subtree split.
>
> Hrm.  This looks like a workaround for a short-sighted misdesign of
> the annotate option that only allowed prefixing a fixed string.  I
> have to wonder if it is better to deprecate --annotate and replace
> it with a more general "commit log rewriting" facility that can
> cover both use cases?

That's not a bad idea. I'd have to think a bit about a sensible design. Do you have any ideas, James?

In the meantime, will you apply the patch or do you prefer a new design?

                      -David