From: Junio C Hamano Date: Sun, 14 Feb 2010 01:37:21 GMT Subject: Re: [PATCH] don't use mmap() to hash files Message-ID: <7vtytk61im.fsf@alter.siamese.dyndns.org> In-Reply-To: <20100214011812.GA2175@dpotapov.dyndns.org> Dmitry Potapov writes: > If a mmapped file is changed by another program during git-add, it > causes the repository corruption. Disabling mmap() in index_fd() does > not have any negative impact on the overall speed of Git. In fact, it > makes git hash-object to work slightly faster.... > ... > I think more people should test this change to see its impact on > performance. For me, it was positive. Here is my results: I wasn't particularly impressed by the original problem description, but this is a very interesting result.