git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 5/5] git-send-email: allow edit invalid email address

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 26, 2012, 17:08 UTC
Message-ID
<7vobikthpp.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1353607932-10436-5-git-send-email-krzysiek@podlesie.net>
Krzysztof Mazur <krzysiek@podlesie.net> writes:
Show 34 quoted lines
> In some cases the user may want to send email with "Cc:" line with
> email address we cannot extract. Now we allow user to extract
> such email address for us.
>
> Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net>
> ---
>  git-send-email.perl | 9 ++++++---
>  1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index d42dca2..9996735 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -851,10 +851,10 @@ sub extract_valid_address_or_die {
>  
>  sub validate_address {
>  	my $address = shift;
> -	if (!extract_valid_address($address)) {
> +	while (!extract_valid_address($address)) {
>  		print STDERR "error: unable to extract a valid address from: $address\n";
> -		$_ = ask("What to do with this address? ([q]uit|[d]rop): ",
> -			valid_re => qr/^(?:quit|q|drop|d)/i,
> +		$_ = ask("What to do with this address? ([q]uit|[d]rop|[e]dit): ",
> +			valid_re => qr/^(?:quit|q|drop|d|edit|e)/i,
>  			default => 'q');
>  		if (/^d/i) {
>  			return undef;
> @@ -862,6 +862,9 @@ sub validate_address {
>  			cleanup_compose_files();
>  			exit(0);
>  		}
> +		$address = ask("Who should the email be sent to (if any)? ",
> +			default => "",
> +			valid_re => qr/\@.*\./, confirm_only => 1);

Not having this new code inside "elsif (/^e/) { }" feels somewhat sloppy, even though it is not *too* bad. Also do we know this function will never be used for addresses other than recipients' (I gave a cursory look to see what is done to the $sender and it does not seem to go through this function, tho)?

Previous: Krzysztof MazurNext: Krzysztof Mazur
Message 26 of 34 in “Failure to extra stable@vger.kernel.org addresses”
  1. Felipe BalbiNov 19, 2012
  2. Krzysztof MazurNov 19, 2012
  3. Felipe BalbiNov 19, 2012
  4. Junio C HamanoNov 19, 2012
  5. Felipe ContrerasNov 19, 2012
  6. Krzysztof MazurNov 19, 2012
  7. Felipe ContrerasNov 19, 2012
  8. Junio C HamanoNov 19, 2012
  9. Krzysztof MazurNov 20, 2012
  10. Krzysztof MazurNov 20, 2012
  11. Felipe ContrerasNov 20, 2012
  12. Andreas EricssonNov 20, 2012
  13. Krzysztof MazurNov 20, 2012
  14. Andreas SchwabNov 20, 2012
  15. Krzysztof MazurNov 20, 2012
  16. Felipe ContrerasNov 20, 2012
  17. Junio C HamanoNov 20, 2012
  18. Krzysztof MazurNov 20, 2012
  19. Junio C HamanoNov 20, 2012
  20. 1/5 git-send-email: remove garbage after email addressKrzysztof Mazur, Nov 22, 2012
  21. 2/5 git-send-email: fix fallback code in extract_valid_address()Krzysztof Mazur, Nov 22, 2012
  22. 3/5 git-send-email: remove invalid addresses earlierKrzysztof Mazur, Nov 22, 2012
  23. Junio C HamanoNov 26, 2012
  24. 4/5 git-send-email: ask what to do with an invalid email addressKrzysztof Mazur, Nov 22, 2012
  25. 5/5 git-send-email: allow edit invalid email addressKrzysztof Mazur, Nov 22, 2012
  26. Junio C HamanoNov 26, 2012
  27. Krzysztof MazurNov 26, 2012
  28. Junio C HamanoNov 26, 2012
  29. Krzysztof MazurNov 26, 2012
  30. Junio C HamanoNov 26, 2012
  31. Krzysztof MazurNov 27, 2012
  32. Junio C HamanoNov 20, 2012
  33. Krzysztof MazurNov 20, 2012
  34. Felipe BalbiNov 20, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.