Failure to extra stable@vger.kernel.org addresses
- From
- Felipe Balbi <balbi@ti.com>
- Date
- Nov 19, 2012, 09:57 UTC
- Message-ID
- <20121119095747.GA13552@arwen.pp.htv.fi>
Hi guys,
for whatever reason my git has started acting up with stable@vger.kernel.org addresses. It doesn't manage to extract a valid adress from the string:
Cc: <stable@vger.kernel.org> # v3.4 v3.5 v3.6
Removing the comment at the end of the line makes things work again. I do remember, however, seeing this working since few weeks back I sent a mail to stable (in fact the same one I'm using to test), so this could be related to some perl updates, who knows ?!?
Anyway, here's output of git-send-email:
Show 20 quoted lines
> $ git send-email --to linux-usb@vger.kernel.org ../linux/0001-usb-dwc3-gadget-fix-endpoint-always-busy-bug.diff --dry-run > ../linux/0001-usb-dwc3-gadget-fix-endpoint-always-busy-bug.diff > (mbox) Adding cc: Felipe Balbi <balbi@ti.com> from line 'From: Felipe Balbi <balbi@ti.com>' > (body) Adding cc: <stable@vger.kernel.org> #v3.4 v3.5 v3.6 from line 'Cc: <stable@vger.kernel.org> #v3.4 v3.5 v3.6' > (body) Adding cc: Felipe Balbi <balbi@ti.com> from line 'Signed-off-by: Felipe Balbi <balbi@ti.com>' > Use of uninitialized value $cc in string eq at /usr/libexec/git-core/git-send-email line 997. > Use of uninitialized value $cc in quotemeta at /usr/libexec/git-core/git-send-email line 997. > W: unable to extract a valid address from: <stable@vger.kernel.org> #v3.4 v3.5 v3.6 > W: unable to extract a valid address from: <stable@vger.kernel.org> #v3.4 v3.5 v3.6 > Dry-OK. Log says: > Sendmail: /usr/bin/msmtp -i linux-usb@vger.kernel.org balbi@ti.com > From: Felipe Balbi <balbi@ti.com> > To: linux-usb@vger.kernel.org > Cc: Felipe Balbi <balbi@ti.com> > Subject: [PATCH] usb: dwc3: gadget: fix 'endpoint always busy' bug > Date: Mon, 19 Nov 2012 11:54:16 +0200 > Message-Id: <1353318856-14987-1-git-send-email-balbi@ti.com> > X-Mailer: git-send-email 1.8.0 > > Result: OK
$ perl --version
This is perl 5, version 14, subversion 2 (v5.14.2) built for x86_64-linux-gnu-thread-multi (with 72 registered patches, see perl -V for more detail)
Copyright 1987-2011, Larry Wall
Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit.
Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page.
And attached you can find the patch file which I'm using
-- balbi From 041d81f493d90c940ec41f0ec98bc7c4f2fba431 Mon Sep 17 00:00:00 2001 From: Felipe Balbi <balbi@ti.com> Date: Thu, 4 Oct 2012 11:58:00 +0300 Subject: [PATCH] usb: dwc3: gadget: fix 'endpoint always busy' bug If a USB transfer has already been started, meaning we have already issued StartTransfer command to that particular endpoint, DWC3_EP_BUSY flag has also already been set. When we try to cancel this transfer which is already in controller's cache, we will not receive XferComplete event and we must clear DWC3_EP_BUSY in order to allow subsequent requests to be properly started. The best place to clear that flag is right after issuing DWC3_DEPCMD_ENDTRANSFER. Cc: <stable@vger.kernel.org> #v3.4 v3.5 v3.6 Reported-by: Moiz Sonasath <m-sonasath@ti.com> Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c index c9e729a..7b7dedd 100644 --- a/drivers/usb/dwc3/gadget.c +++ b/drivers/usb/dwc3/gadget.c @@ -1904,7 +1904,7 @@ static void dwc3_stop_active_transfer(struct dwc3 *dwc, u32 epnum) ret = dwc3_send_gadget_ep_cmd(dwc, dep->number, cmd, ¶ms); WARN_ON_ONCE(ret); dep->resource_index = 0; - + dep->flags &= ~DWC3_EP_BUSY; udelay(100); } -- 1.8.0