Re: [PATCH 5/5] git-send-email: allow edit invalid email address

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 26, 2012, 22:58 UTC
Message-ID: <7vhaocotsd.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20121126173318.GA12101@shrek.podlesie.net>

Krzysztof Mazur <krzysiek@podlesie.net> writes:

Show 12 quoted lines

>> Not having this new code inside "elsif (/^e/) { }" feels somewhat
>> sloppy, even though it is not *too* bad.  Also do we know this
>
> ok, I will fix that.
>
>> function will never be used for addresses other than recipients' (I
>> gave a cursory look to see what is done to the $sender and it does
>> not seem to go through this function, tho)?
>
> Yes, this function is called only from validate_address_just()
> to filter @initial_to, @initial_cc, @bcc_list as early as possible,
> and filter @to and @cc added in each email.

Thanks; when merged to 'pu', this series seems to break t9001. I'll push the result out with breakages but could you take a look?

Test Summary Report
-------------------
t9001-send-email.sh                              (Wstat: 256 Tests: 102 Failed: 77)
  Failed tests:  4-7, 9-10, 12-13, 15, 17-21, 23-29, 31-33
                35, 37, 39, 41, 43, 45, 47, 49, 51-58, 61-88
                91, 93-95, 98-102
  Non-zero exit status: 1