Re: Failure to extra stable@vger.kernel.org addresses

From: Krzysztof Mazur <krzysiek@podlesie.net>
Date: Nov 20, 2012, 07:15 UTC
Message-ID: <20121120071516.GA7206@shrek.podlesie.net>
In-Reply-To: <7vhaoluos6.fsf@alter.siamese.dyndns.org>

On Mon, Nov 19, 2012 at 04:00:09PM -0800, Junio C Hamano wrote:

Show 14 quoted lines

> Krzysztof Mazur <krzysiek@podlesie.net> writes:
> 
> > On Mon, Nov 19, 2012 at 11:27:45AM -0800, Junio C Hamano wrote:
> >> Given that the problematic line
> >> 
> >> 	Stable Kernel Maintainance Track <stable@vger.kernel.org> # vX.Y
> >> 
> >> is not even a valid e-mail address, doesn't this new logic belong to
> >> sanitize_address() conceptually?
> >
> > Yes, it's much better to do it in the sanitize_address().
> 
> Note that I did not check that all the addresses that are handled by
> extract-valid-address came through sanitize-address function, so

Before sending that patch, I checked that and tested with and without Email::Valid.

> unlike your original patch, this change alone may still pass some
> garbage to Email::Valid->address().  I tend to think that is a
> progress; we should make sure all the addresses are sanitized before
> using them for sending messages out.

I will try to check that.

Krzysiek