[PATCH 1/5] git-send-email: remove garbage after email address
- From
- Krzysztof Mazur <krzysiek@podlesie.net>
- Date
- Nov 22, 2012, 18:12 UTC
- Message-ID
- <1353607932-10436-1-git-send-email-krzysiek@podlesie.net>
- In-Reply-To
- <7v8v9vrgc9.fsf@alter.siamese.dyndns.org>
In some cases it's very useful to add some additional information after email in Cc-list, for instance:
"Cc: Stable kernel <stable@vger.kernel.org> #v3.4 v3.5 v3.6"
Currently the git refuses to add such invalid email to Cc-list, when the Email::Valid perl module is available or just uses whole line as the email address.
Now in sanitize_address() everything after the email address is removed, so the resulting line is correct email address and Email::Valid validates it correctly.
Signed-off-by: Krzysztof Mazur <krzysiek@podlesie.net> Tested-by: Felipe Balbi <balbi@ti.com> --- git-send-email.perl | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/git-send-email.perl b/git-send-email.perl index 5a7c29d..9840d0a 100755 --- a/git-send-email.perl +++ b/git-send-email.perl @@ -924,6 +924,10 @@ sub quote_subject { # use the simplest quoting being able to handle the recipient sub sanitize_address { my ($recipient) = @_; + + # remove garbage after email address + $recipient =~ s/(.*>).*$/$1/; + my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/); if (not $recipient_name) {
-- 1.8.0.393.gcc9701d