Re: Failure to extra stable@vger.kernel.org addresses
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 20, 2012, 00:00 UTC
- Message-ID
- <7vhaoluos6.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20121119225838.GA23412@shrek.podlesie.net>
Krzysztof Mazur <krzysiek@podlesie.net> writes:
Show 9 quoted lines
> On Mon, Nov 19, 2012 at 11:27:45AM -0800, Junio C Hamano wrote: >> Given that the problematic line >> >> Stable Kernel Maintainance Track <stable@vger.kernel.org> # vX.Y >> >> is not even a valid e-mail address, doesn't this new logic belong to >> sanitize_address() conceptually? > > Yes, it's much better to do it in the sanitize_address().
Note that I did not check that all the addresses that are handled by extract-valid-address came through sanitize-address function, so unlike your original patch, this change alone may still pass some garbage to Email::Valid->address(). I tend to think that is a progress; we should make sure all the addresses are sanitized before using them for sending messages out.