Re: Failure to extra stable@vger.kernel.org addresses

From: Krzysztof Mazur <krzysiek@podlesie.net>
Date: Nov 20, 2012, 11:59 UTC
Message-ID: <20121120115942.GA6132@shrek.podlesie.net>
In-Reply-To: <CAMP44s38gTB_3Ao1rFZgMo2EAuiNb+h88-qRFcQPRMJNxo3CAQ@mail.gmail.com>

On Tue, Nov 20, 2012 at 11:28:39AM +0100, Felipe Contreras wrote:

Show 18 quoted lines

> On Tue, Nov 20, 2012 at 8:56 AM, Krzysztof Mazur <krzysiek@podlesie.net> wrote:
> 
> > --- a/git-send-email.perl
> > +++ b/git-send-email.perl
> > @@ -925,8 +925,11 @@ sub quote_subject {
> >  sub sanitize_address {
> >         my ($recipient) = @_;
> >
> > +       my $local_part_regexp = qr/[^<>"\s@]+/;
> > +       my $domain_regexp = qr/[^.<>"\s@]+(?:\.[^.<>"\s@]+)+/;
> > +
> >         # remove garbage after email address
> > -       $recipient =~ s/(.*>).*$/$1/;
> > +       $recipient =~ s/^(.*?<$local_part_regexp\@$domain_regexp>).*/$1/;
> 
> I don't think all that extra complexity is warranted, to me
> s/(.*?>)(.*)$/$1/ is just fine.
>

Yeah, it's a little bit too complex, but "s/(.*?>)(.*)$/$1/" causes small regression - '>' character is no longer allowed in "phrase" before "<email address>". Maybe the initial version, that removes everything after last '>' is better? In this case '>' is not allowed in garbage after email.

Krzysiek