From: Junio C Hamano Date: Mon, 16 Jul 2012 19:03:40 GMT Subject: Re: [PATCH v2] Fix notes handling in rev-list Message-ID: <7vipdn1qb7.fsf@alter.siamese.dyndns.org> In-Reply-To: <1342463409-6919-1-git-send-email-jukka.lehtniemi@gmail.com> Jukka Lehtniemi writes: > Display notes in the rev-list when switch '--notes' is used. > Also expand notes place holder (%N) in user format. > Previously rev-list ignored both of these. > > Signed-off-by: Jukka Lehtniemi > --- > > Thanks for your feedback Peff! If it is an update for some old patch (I am guessing that is the case from "v2" and "feedback" above), please hint where the original can be found not to waste reviewers' time. As "git rev-list -h" does not say anything about "notes", I do not think this should be even called "Fix"; rather it is "teach rev-list to show notes with --notes", a new feature. And as a new feature, "git rev-list -h" should be taught to include this new option in its output. I didn't check the documentation but you may also want to add --notes there, too (hint: grep for "--pretty" to find where you may need to add the new option).