git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/1] Diff-helper update

From
Junio C Hamano <junkio@cox.net>
Date
May 18, 2005, 23:54 UTC
Message-ID
<7vacmsnl92.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0505181338270.18337@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> On Wed, 18 May 2005, Junio C Hamano wrote:
>> 
>> I suspect doing something like this might be saner instead,
>> assuming non raw-diffs come at the end.  
LT> It won't ever trigger, since we only exit the loop once we see EOF.

I was not talking about correctness, but the readability of the code. Breaking out from the loop to process raw-diff and switching to straight copy would make our intent more explicit.

Previous: Linus TorvaldsNext: Junio C Hamano
Message 9 of 13 in “Diff-helper update”
  1. 0/1 Diff-helper updateJunio C Hamano, May 18, 2005
  2. Linus TorvaldsMay 18, 2005
  3. Junio C HamanoMay 18, 2005
  4. Linus TorvaldsMay 18, 2005
  5. Linus TorvaldsMay 18, 2005
  6. Thomas GlanzmannMay 18, 2005
  7. Junio C HamanoMay 18, 2005
  8. Linus TorvaldsMay 18, 2005
  9. Junio C HamanoMay 18, 2005
  10. Junio C HamanoMay 19, 2005
  11. [preview] diff-helper rename detection.Junio C Hamano, May 19, 2005
  12. Linus TorvaldsMay 19, 2005
  13. Junio C HamanoMay 19, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.