git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [preview] diff-helper rename detection.

From
Junio C Hamano <junkio@cox.net>
Date
May 19, 2005, 03:08 UTC
Message-ID
<7vk6lvnc94.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<Pine.LNX.4.58.0505181952260.2322@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> I suspect that one tweak may be to try to find the "best" rename first, LT> rather than look at files in the order they were discovered (ie you'd LT> create a _matrix_ of the delta scores, rather than walk through the newly LT> created files in order). That would then potentially allow for a more LT> relaxed definitions of "rename", without any possibility of losing sight LT> of a better rename due to finding a bad one first.

I thought about that but I opted for simplicity of first picking the exact matches. I was unsure about the usefulness of relaxed matching to begin with. But I now realize that to see how useful that would be we need to experiment it and a matrix approach would become necessity for that.

LT> So my only nit so far is that you declare "patch_delta()", LT> even though you don't actually have it. Just remove it.

I'd rather keep that file as is for later merge with Nico. It came from the delitification patch and I tried to keep the new files as they are.

Previous: Linus Torvalds
Message 13 of 13 in “Diff-helper update”
  1. 0/1 Diff-helper updateJunio C Hamano, May 18, 2005
  2. Linus TorvaldsMay 18, 2005
  3. Junio C HamanoMay 18, 2005
  4. Linus TorvaldsMay 18, 2005
  5. Linus TorvaldsMay 18, 2005
  6. Thomas GlanzmannMay 18, 2005
  7. Junio C HamanoMay 18, 2005
  8. Linus TorvaldsMay 18, 2005
  9. Junio C HamanoMay 18, 2005
  10. Junio C HamanoMay 19, 2005
  11. [preview] diff-helper rename detection.Junio C Hamano, May 19, 2005
  12. Linus TorvaldsMay 19, 2005
  13. Junio C HamanoMay 19, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.