Re: [preview] diff-helper rename detection.
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 19, 2005, 03:08 UTC
- Message-ID
- <7vk6lvnc94.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <Pine.LNX.4.58.0505181952260.2322@ppc970.osdl.org>
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> I suspect that one tweak may be to try to find the "best" rename first, LT> rather than look at files in the order they were discovered (ie you'd LT> create a _matrix_ of the delta scores, rather than walk through the newly LT> created files in order). That would then potentially allow for a more LT> relaxed definitions of "rename", without any possibility of losing sight LT> of a better rename due to finding a bad one first.
I thought about that but I opted for simplicity of first picking the exact matches. I was unsure about the usefulness of relaxed matching to begin with. But I now realize that to see how useful that would be we need to experiment it and a matrix approach would become necessity for that.
LT> So my only nit so far is that you declare "patch_delta()", LT> even though you don't actually have it. Just remove it.
I'd rather keep that file as is for later merge with Nico. It came from the delitification patch and I tried to keep the new files as they are.