Re: [PATCH 0/1] Diff-helper update

From: Linus Torvalds <torvalds@osdl.org>
Date: May 18, 2005, 18:38 UTC
Message-ID: <Pine.LNX.4.58.0505181134470.18337@ppc970.osdl.org>
In-Reply-To: <Pine.LNX.4.58.0505181110480.18337@ppc970.osdl.org>

On Wed, 18 May 2005, Linus Torvalds wrote:

> 
> If diff-helper just passes the lines it doesn't understand through
> unmodified (_after_ having handled any pending rename logic), it will 
> automatically do the right thing.

I took the liberty of doing just that. The only subtle issue was that the strbuf functions would consider an empty line to be EOF, which looked wrong and unintentional. Fixing that made the actual diff-helper changes totally trivial, and I can now do

	git-rev-list HEAD | git-diff-tree -r -v --stdin | ./git-diff-helper -r | less -S

and it does the right thing for me.

		Linus