Re: [PATCH 0/1] Diff-helper update
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 19, 2005, 11:11 UTC
- Message-ID
- <7vis1f1ne2.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <7vacmsnl92.fsf@assigned-by-dhcp.cox.net>
>>>>> "JCH" == Junio C Hamano <junkio@cox.net> writes:
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> On Wed, 18 May 2005, Junio C Hamano wrote:
>>> >>> I suspect doing something like this might be saner instead, >>> assuming non raw-diffs come at the end.
LT> It won't ever trigger, since we only exit the loop once we see EOF.
JCH> I was not talking about correctness, but the readability of the JCH> code. Breaking out from the loop to process raw-diff and JCH> switching to straight copy would make our intent more explicit.
I was completely mistaken about what you were talking about. Your output (helper's input) is (<non-diff material>* <raw-diff material>*)*, so of course we should not break out of the main loop.