Re: [PATCH 0/1] Diff-helper update

From: Linus Torvalds <torvalds@osdl.org>
Date: May 18, 2005, 18:14 UTC
Message-ID: <Pine.LNX.4.58.0505181110480.18337@ppc970.osdl.org>
In-Reply-To: <7v64xgpgb0.fsf@assigned-by-dhcp.cox.net>

On Wed, 18 May 2005, Junio C Hamano wrote:

Show 8 quoted lines

> >>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
> 
> LT> However, git-diff-helper doesn't understand these things, and the builtin
> LT> diff doesn't do the rename thing. Yet it would be very very useful to do.
> 
> It is unclear what you meant by "these things" in "doesn't
> understand these things", and what you meant by "it" in "it
> would be very very useful to do."  Could you explain?

"These things" being the extra output from "diff-tree" that is not a "diff line".

If diff-helper just passes the lines it doesn't understand through unmodified (_after_ having handled any pending rename logic), it will automatically do the right thing.

Show 5 quoted lines

> About the built-in diff not doing the rename , I have a bit
> longer term (knowing _my_ timescale I'd imagine you would
> understand that is not that long ;-) plan to have -p option for
> diff-* family to use the same rename detection logic that I
> added to diff-helper in the patch you are commenting on.

Goodie. I was hoping that was the case, but felt that the diff-helper thing should be pretty easy to do.

			Linus