Re: [preview] diff-helper rename detection.

From: Linus Torvalds <torvalds@osdl.org>
Date: May 19, 2005, 03:01 UTC
Message-ID: <Pine.LNX.4.58.0505181952260.2322@ppc970.osdl.org>
In-Reply-To: <7vr7g4m0lz.fsf_-_@assigned-by-dhcp.cox.net>

On Wed, 18 May 2005, Junio C Hamano wrote:

Show 6 quoted lines

> 
> This is not yet a request for inclusion but is a preview
> requesting for testing and comments, especially from Linus (for
> general usability comments and suggestions for cut-off-points in
> heuristics) and Nico (in case I had blatantly misused the
> diff-delta interface).

I think this is great, although I also bet that we'll tweak the heuristics later.

I suspect that one tweak may be to try to find the "best" rename first, rather than look at files in the order they were discovered (ie you'd create a _matrix_ of the delta scores, rather than walk through the newly created files in order). That would then potentially allow for a more relaxed definitions of "rename", without any possibility of losing sight of a better rename due to finding a bad one first.

But I think the simple heurstic is probably fine as a first cut.

So my only nit so far is that you declare "patch_delta()", even though you don't actually have it. Just remove it.

		Linus