From: Junio C Hamano <junkio@cox.net>
Date: Wed, 18 May 2005 23:54:17 GMT
Subject: Re: [PATCH 0/1] Diff-helper update
Message-ID: <7vacmsnl92.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <Pine.LNX.4.58.0505181338270.18337@ppc970.osdl.org>

>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:

LT> On Wed, 18 May 2005, Junio C Hamano wrote:
>> 
>> I suspect doing something like this might be saner instead,
>> assuming non raw-diffs come at the end.  

LT> It won't ever trigger, since we only exit the loop once we see EOF.

I was not talking about correctness, but the readability of the
code.  Breaking out from the loop to process raw-diff and
switching to straight copy would make our intent more explicit.