Re: [PATCH v2] completion: add new git_complete helper

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 16, 2012, 20:51 UTC
Message-ID: <7v7gxftn78.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20120416203320.GF12613@burratino>

Jonathan Nieder <jrnieder@gmail.com> writes:

Show 16 quoted lines

> Felipe Contreras wrote:
>> On Mon, Apr 16, 2012 at 11:09 PM, Jonathan Nieder <jrnieder@gmail.com> wrote:
>>> Felipe Contreras wrote:
>
>>>> I would like to see a completion script that actually has a function
>>>> supposed to be exported and that still uses the _ prefix anyway.
>>>
>>> The /etc/bash_completion library itself exports lots and lots of
>>> functions with a _ prefix.
>>
>> We are not making a bash_completion library; I mean a bash completion
>> script (other than the library).
>
> Ok.  If you refuse to put two and two together, then I will (as usual
> when this happens) just be a little passive aggressive and annoyed and
> let you talk to other people.

I have been assuming that bash_completion library is a sort of metaproject whose sole purpose is to supply a framework for completion scripts for other packages like Git to be plugged easily and give niceties like lazy loading to avoid inflicting undue latencies to the end users.

Earlier I said "Ok" to you based on that assumption; somebody may have his own git_complete that rebuilds a test integration branch (i.e. completes it) and having the name git_complete exported by us will indirectly affect her fingers if she installs bash_completion and Git package on her system.

But that assumption may not be correct, or even if it is correct, Felipe may be missing that part, so it may not be "refusing to add two and two", but could be "learned two, but do not know the number of the other side of addition".