Re: [PATCH v2] completion: add new git_complete helper

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 17, 2012, 18:15 UTC
Message-ID: <7v4nsins1j.fsf@alter.siamese.dyndns.org>
In-Reply-To: <CAMP44s1sj27U_s3Y3nLL6pkMrPMVvTo982c85x-hH5szvprK0g@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

Show 17 quoted lines

> On Tue, Apr 17, 2012 at 6:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
>> Felipe Contreras <felipe.contreras@gmail.com> writes:
> ...
>>>> And foo_wrap() should also fit into those namespaces.
>>>
>>> Yeah, I don't have a problem with that, just forgot about it.
>>>
>>> But git_complete I think is different.
>>
>> Is git_complete something the user types interactively, or is it meant to
>> be used in their .bashrc to help them complete arguments to their custom
>> scripts that take arguments similar to Git Porcelains?
>
> It's meant for their .bashrc, but can be used interactively, exactly
> like 'complete'. You can type 'complete -o bashdefault -o default -o
> nospace -F _git git' in the command like, but that would rarely
> happen.

OK, then I do not think "as a public interface it looks somewhat ugly" (which I happen to think, and I am guessing that you agree with) matters. It looks to me that it would be sane to follow the convention to avoid accidental name clashes with userspace names by naming it "__git_complete" in that case.