Re: [PATCH v2] completion: add new git_complete helper
- From
SZEDER Gábor <szeder@ira.uka.de>
- Date
- Apr 16, 2012, 22:15 UTC
- Message-ID
- <20120416221531.GA2299@goldbirke>
- In-Reply-To
- <20120415213718.GB5813@burratino>
Hi,
On Sun, Apr 15, 2012 at 04:37:18PM -0500, Jonathan Nieder wrote:
Show 13 quoted lines
> Felipe Contreras wrote: > > > This simplifies the completions, and makes it easier to define aliases: > > > > git_complete gf git_fetch > > Sounds neat. Unfortunately users could already be using a function > with some other purpose named git_complete in their .profile and this > would override it. The completion script has so far stuck to a > limited namespace: > > _git_* (completion functions) > __git_* (everything else, including public interfaces like __git_ps1)
Don't forget the oddball __gitdir() function ;)
> A name like __git_complete should work, presumably.
And foo_wrap() should also fit into those namespaces.
Best, Gábor